-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace XMLHttpRequest usage with the Fetch API in inlineImages
(in test/driver.js
)
#14651
Replace XMLHttpRequest usage with the Fetch API in inlineImages
(in test/driver.js
)
#14651
Conversation
… `test/driver.js`) This is the final part in a series of patches that try to re-implement PR 14287 in smaller steps. Besides converting `inlineImages` to use the Fetch API, this patch also combines the `inlineImages` and `resolveImages` functions since they are always used together.
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/56d04652711eb76/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f23aecad614714f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/56d04652711eb76/output.txt Total script time: 19.86 mins
Image differences available at: http://54.241.84.105:8877/56d04652711eb76/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f23aecad614714f/output.txt Total script time: 20.07 mins
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8ac8bf0c628b991/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1ad95f3b1c7b0b2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8ac8bf0c628b991/output.txt Total script time: 23.85 mins
Image differences available at: http://54.241.84.105:8877/8ac8bf0c628b991/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1ad95f3b1c7b0b2/output.txt Total script time: 26.14 mins
|
Thank you for doing this; much better without the indirection! |
This is the final part in a series of patches that try to re-implement PR #14287 in smaller steps.
Besides converting
inlineImages
to use the Fetch API, this patch also combines theinlineImages
andresolveImages
functions since they are always used together.