Enable the no-empty-character-class and no-template-curly-in-string linting rules
#13788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g` linting rules The former prevents unintended errors in regexes. The latter is something I ran into a couple of times before editors had proper support for syntax highlighting in template literals, and it's an easy mistake to make, especially when converting older code to use template literals. Nowadays most editors display template literals in different colors, but nevertheless it seems like a good idea to enable this rule. Fortunately both rules don't require any code changes, so it's more for prevention.
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/d75f3113cc1aef2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/d4374f43baac4c0/output.txt |
Snuffleupagus
approved these changes
Jul 24, 2021
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d75f3113cc1aef2/output.txt Total script time: 2.49 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/d4374f43baac4c0/output.txt Total script time: 3.99 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former prevents unintended errors in regexes. The latter is something I ran into a couple of times before editors had proper support for syntax highlighting in template literals, and it's an easy mistake to make, especially when converting older code to use template literals. Nowadays most editors display template literals in different colors, but nevertheless it seems like a good idea to enable this rule.
Fortunately both rules don't require any code changes, so it's more for prevention.
Refer to https://eslint.org/docs/rules/no-empty-character-class and https://eslint.org/docs/rules/no-template-curly-in-string for more information about those rules.