When parsing corrupt documents, avoid inserting obviously broken data in the XRef-table (issue 13783) #13784
Conversation
… in the XRef-table (issue 13783) In cases where even the very *first* attempt at reading from an object will throw, simply ignoring such objects will help improve rendering of *some* corrupt documents. Note that this will lead to more parsing in some cases, but considering that this only applies to *corrupt* documents that shouldn't be a big deal.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aa3bb5482babf2f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/fa5ed121bacd196/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/aa3bb5482babf2f/output.txt Total script time: 32.67 mins
Image differences available at: http://54.67.70.0:8877/aa3bb5482babf2f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/fa5ed121bacd196/output.txt Total script time: 38.96 mins
Image differences available at: http://3.101.106.178:8877/fa5ed121bacd196/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2827c135f5080e9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2827c135f5080e9/output.txt Total script time: 5.25 mins Published |
|
Looks good to me; thank you! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/5c844242b9ed3f5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://3.101.106.178:8877/0f46576f89ca25b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5c844242b9ed3f5/output.txt Total script time: 29.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0f46576f89ca25b/output.txt Total script time: 34.98 mins
|
In cases where even the very first attempt at reading from an object will throw, simply ignoring such objects will help improve rendering of some corrupt documents.
Note that this will lead to more parsing in some cases, but considering that this only applies to corrupt documents that shouldn't be a big deal.