Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include most of the test-folder in the LGTM report (PR 13772 follow-up) #13776

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Given that PR #13772 seem to have worked as intended, it probably cannot hurt to enable the LGTM report for most of the remaining code in the test-folder. (The one remaining exception is code which originated outside of the PDF.js project.)

Please note: We'll need to land this patch to actually see any difference in the LGTM results.

…-up)

Given that PR 13772 seem to have worked as intended, it probably cannot hurt to enable the LGTM report for *most* of the remaining code in the `test`-folder. (The one remaining exception is code which originated *outside* of the PDF.js project.)

*Please note:* We'll need to land this patch to actually see any difference in the LGTM results.
@Snuffleupagus Snuffleupagus merged commit 1815800 into mozilla:master Jul 22, 2021
@Snuffleupagus
Copy link
Collaborator Author

I'm going to make an exception and land this without waiting for review, since:

  • We cannot tell if this actually works as intended, without landing the patch.
  • The patch is very small and simple, and only applies to the LGTM-integration.
  • Finally, and most importantly, none of this code applies to the built PDF.js library and cannot possibly affect rendering, the viewer, or any other even remotely critical functionality.

@Snuffleupagus Snuffleupagus deleted the lgtm-more-test branch July 22, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant