Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - A rectangle must have the width of its parent but without inner margins #13732

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/295e69131233d05/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/3f82923cd0d0ace/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/295e69131233d05/output.txt

Total script time: 33.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 243
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/295e69131233d05/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

Something is wrong with dhl test.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/3f82923cd0d0ace/output.txt

Total script time: 37.59 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 243
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/3f82923cd0d0ace/reftest-analyzer.html#web=eq.log

… margins

  - it aims to fix mozilla#13584;
  - to avoid bad rendering because of clipping just set overflow to visible on SVG element.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7789d25cd64de4a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/28c635128516d41/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/28c635128516d41/output.txt

Total script time: 32.92 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 242
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/28c635128516d41/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/7789d25cd64de4a/output.txt

Total script time: 37.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 243

Image differences available at: http://3.101.106.178:8877/7789d25cd64de4a/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Jul 14, 2021

firefox-xfa_bug1716380-page2 and firefox-xfa_bug1716809-page1 look a bit worse

@calixteman
Copy link
Contributor Author

For example, in xfa_bug1716809.pdf the rectangle around "Interesado" is drawn thanks to a border when the content just after are inside a svg rect and it seems that they rendered differently at least for non-integer stroke widths (0.5px here).
I tested locally in the viewer and I'd say that the diff is acceptable: before the patch some lines disappeared at some zoom levels (the parent div was clipping the svg rect which has non-integer stroke width).
Maybe we should either use a border to render a rect or use a rect to render a border to have at least something consistent when drawing some lines.

@marco-c
Copy link
Contributor

marco-c commented Jul 15, 2021

The regressions are minor, so we will accept them.

@marco-c
Copy link
Contributor

marco-c commented Jul 15, 2021

@calixteman can you file an issue to track the (minor) regression?

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/010bcd80d1cd3d6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/224e83afccc6ed5/output.txt

@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/22df37bf46e0db2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 2

Live output at: http://3.101.106.178:8877/11a16696e0fc8f7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/010bcd80d1cd3d6/output.txt

Total script time: 32.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 240
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/010bcd80d1cd3d6/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/224e83afccc6ed5/output.txt

Total script time: 39.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 245
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/224e83afccc6ed5/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/22df37bf46e0db2/output.txt

Total script time: 29.37 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/11a16696e0fc8f7/output.txt

Total script time: 35.60 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the rect branch July 16, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XFA Geometry exceeds containers
3 participants