Fixed text annotation comb input box #13690
Conversation
There was a problem hiding this comment.
Please don't include unrelated files in your patches, hence the package-lock.json must be removed.
Furthermore, have you successfully tested this manually in the viewer and do all of the tests pass with this patch?
Note that these changes are from PR #7649, and see also https://github.com/mozilla/pdf.js/wiki/Contributing#4-run-lint-and-testing
Finally, please provide a meaningful commit-message (and PR description) that actually describes the changes; note that "Solves issue #12865" isn't really helpful/useful in general.
|
So basically a CSS focus event style was modifying the input box width whenever the input box got focus. It modified the width from 100% to 115%. According to a comment in there, it was done to adjust the letter spacing of the characters in that input box. I have reduced the expanded width from 115% to 103% and it works fine now and passes all the unit tests/reference image tests successfully. |
91028a0 to
d7daca2
Compare
d7daca2 to
e34e2e0
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/6a169706eb2f08e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6a169706eb2f08e/output.txt Total script time: 4.96 mins Published |
|
I did a quick check with my original PDF file and so far it looks like this works. Note that this is dynamic behavior that the tests can't cover, so because we have to rely on manual testing here I'd like to take some more time to play with more PDFs later to make sure it works in all scenarios. |
I get your point. I have checked in some sample PDFs from my side as well, seems fine. Let me know if you find any malfunction. |
|
Hey, any updates? @timvandermeij |
|
Thank you for your contribution! |
I have tried to address issue #12865. Please look at it and suggest changes if any.