[test/driver.js] Ensure that Image src is set *after* the callbacks in resolveImages
#13675
Conversation
… in `resolveImages` *While I cannot guarantee that this will fix the recent intermittents, this patch really shouldn't hurt.* By setting the Image `src` first, there's a small possibility that the Image is loaded *before* we've had a change to attach the `onload`/`onerror` callbacks which may cause the Promise to remain in a pending state. Note that prior to PR 13641 we didn't correctly await all image resources to actually load, which could explain the very recent intermittent test-failures.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/7d3c2ce66de405f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/dd684a5d775e961/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/dd684a5d775e961/output.txt Total script time: 34.84 mins
Image differences available at: http://3.101.106.178:8877/dd684a5d775e961/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/7d3c2ce66de405f/output.txt Total script time: 24.05 mins
Image differences available at: http://54.67.70.0:8877/7d3c2ce66de405f/reftest-analyzer.html#web=eq.log |
|
Apparently this didn't help :-( |
I'd say landing it doesn't hurt and might be useful, so... let's land it? |
While I cannot guarantee that this will fix the recent intermittents, this patch really shouldn't hurt.
By setting the Image
srcfirst, there's a small possibility that the Image is loaded before we've had a change to attach theonload/onerrorcallbacks which may cause the Promise to remain in a pending state.Note that prior to PR #13641 we didn't correctly await all image resources to actually load, which could explain the very recent intermittent test-failures.