-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XFA - An image can be a stream in the pdf (bug 1718521) #13654
Conversation
calixteman
commented
Jul 2, 2021
- hrefs can be found in catalog > Names > XFAImages
src/core/catalog.js
Outdated
const nameTree = new NameTree(obj.getRaw("XFAImages"), this.xref); | ||
for (const [key, value] of nameTree.getAll()) { | ||
if (!xfaImages) { | ||
xfaImages = new Dict(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you absolutely sure that the Streams inserted into this dictionary cannot ever contain indirect objects anywhere (given all the weird things some PDF generators do)?
If not, I'd definitely suggest just using new Dict(this.xref);
instead to avoid any future bugs (however unlikely).
- hrefs can be found in catalog > Names > XFAImages
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/37403dcb60ac439/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/d642d2231b80213/output.txt |
const nameTree = new NameTree(obj.getRaw("XFAImages"), this.xref); | ||
for (const [key, value] of nameTree.getAll()) { | ||
if (!xfaImages) { | ||
xfaImages = new Dict(this.ref); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: this.ref
-> this.xref
@calixteman This is causing failures all over the place, looking at the |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/37403dcb60ac439/output.txt Total script time: 24.84 mins
|
Sorry about that I thought I ran the tests... |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/d642d2231b80213/output.txt Total script time: 29.13 mins
|