Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - An image can be a stream in the pdf (bug 1718521) #13654

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

calixteman
Copy link
Contributor

  • hrefs can be found in catalog > Names > XFAImages

@calixteman calixteman changed the title XFA - An image can be a stream in the pdf XFA - An image can be a stream in the pdf (bug 1718521) Jul 2, 2021
const nameTree = new NameTree(obj.getRaw("XFAImages"), this.xref);
for (const [key, value] of nameTree.getAll()) {
if (!xfaImages) {
xfaImages = new Dict(null);
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you absolutely sure that the Streams inserted into this dictionary cannot ever contain indirect objects anywhere (given all the weird things some PDF generators do)?
If not, I'd definitely suggest just using new Dict(this.xref); instead to avoid any future bugs (however unlikely).

  - hrefs can be found in catalog > Names > XFAImages
@calixteman calixteman merged commit b370d47 into mozilla:master Jul 5, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/37403dcb60ac439/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/d642d2231b80213/output.txt

const nameTree = new NameTree(obj.getRaw("XFAImages"), this.xref);
for (const [key, value] of nameTree.getAll()) {
if (!xfaImages) {
xfaImages = new Dict(this.ref);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: this.ref -> this.xref

@Snuffleupagus
Copy link
Collaborator

@calixteman This is causing failures all over the place, looking at the makeref logs.
Please back this out for now, and re-land once that's fixed and the tests have actually been run (since makeref without running tests first is always risky).

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/37403dcb60ac439/output.txt

Total script time: 24.84 mins

  • Lint: Passed
  • Make references: FAILED

@calixteman
Copy link
Contributor Author

@calixteman This is causing failures all over the place, looking at the makeref logs.
Please back this out for now, and re-land once that's fixed and the tests have actually been run (since makeref without running tests first is always risky).

Sorry about that I thought I ran the tests...

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/d642d2231b80213/output.txt

Total script time: 29.13 mins

  • Lint: Passed
  • Make references: FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants