Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-PRODUCTION/TESTING overflow asserts to various string helper-functions (issue 6759) #13640

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6759

@Snuffleupagus Snuffleupagus changed the title Add non-PRODUCTION/TESTING asserts to various string helper-functions (issue 6759) Add non-PRODUCTION/TESTING overflow asserts to various string helper-functions (issue 6759) Jun 27, 2021
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.67.70.0:8877/e83a3cf7ec64d4d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://3.101.106.178:8877/3ca384eed4788e1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/e83a3cf7ec64d4d/output.txt

Total script time: 28.81 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/e83a3cf7ec64d4d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/3ca384eed4788e1/output.txt

Total script time: 32.57 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/3ca384eed4788e1/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/d2de3805db66bb1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/25cc447653857e5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/25cc447653857e5/output.txt

Total script time: 1.97 mins

  • Font Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/d2de3805db66bb1/output.txt

Total script time: 4.41 mins

  • Font Tests: Passed

@timvandermeij timvandermeij merged commit 6307349 into mozilla:master Jun 29, 2021
@timvandermeij
Copy link
Contributor

Looks like a good idea to have this; thanks!

@Snuffleupagus Snuffleupagus deleted the issue-6759 branch June 29, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overflow assertions to the various string<int> functions
3 participants