-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XFA - Add margins if needed after having layout some text #13594
Conversation
calixteman
commented
Jun 20, 2021
- it aims to fix the text misplacement found in https://bugzilla.mozilla.org/show_bug.cgi?id=1716380.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run the reftests and ensure all changes are OK?
My bad, I thought we already have the file in the bug in the suite. |
6e89ba3
to
7e38222
Compare
7e38222
to
aca102a
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a8ea2721e08ff21/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://3.101.106.178:8877/6e7e728c2b9e535/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a8ea2721e08ff21/output.txt Total script time: 28.52 mins
Image differences available at: http://54.67.70.0:8877/a8ea2721e08ff21/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6e7e728c2b9e535/output.txt Total script time: 32.25 mins
Image differences available at: http://3.101.106.178:8877/6e7e728c2b9e535/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ if you're fine with the changes in xfa_issue13500
. They seem mostly better, but I'm not sure if you're expecting that.
I think the diff is correct but this pdf has other errors I need to fix. |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8bdd153416c608c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 1 Live output at: http://3.101.106.178:8877/1c7b4d6b6808ffd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8bdd153416c608c/output.txt Total script time: 25.21 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/1c7b4d6b6808ffd/output.txt Total script time: 29.70 mins
|