Fix how patterns are applied to image mask objects. #13565
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://3.101.106.178:8877/f1067a34acc46ad/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://54.67.70.0:8877/77d2b33569f5e04/output.txt |
src/display/canvas.js
Outdated
| @@ -193,6 +197,18 @@ function addContextCurrentTransform(ctx) { | |||
| }; | |||
| } | |||
|
|
|||
| function getAdjustmentTransformation(transform, width, height) { | |||
| // The pattern will be created at the size of the current page or form | |||
| // object, but the the mask is usually scaled differently and | |||
There was a problem hiding this comment.
Nit: the the -> the
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/77d2b33569f5e04/output.txt Total script time: 27.24 mins
Image differences available at: http://54.67.70.0:8877/77d2b33569f5e04/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/f1067a34acc46ad/output.txt Total script time: 31.25 mins
Image differences available at: http://3.101.106.178:8877/f1067a34acc46ad/reftest-analyzer.html#web=eq.log |
Note, this only really fixes Radial/Axial shading patterns with masks. I'm guessing tiling patterns and mesh patterns would also be broken if applied like the test pdf. Hopefully I'll have some time to make test cases for the other shadings. Fixes mozilla#13372
f4c6a1a to
5efaaa0
Compare
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/786cfb73c1edbe7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 1 Live output at: http://3.101.106.178:8877/c79737fe1dd3c50/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/786cfb73c1edbe7/output.txt Total script time: 23.90 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/c79737fe1dd3c50/output.txt Total script time: 28.36 mins
|
Note, this only really fixes Radial/Axial shading patterns with masks.
I'm guessing tiling patterns and mesh patterns would also be broken
if applied like the test pdf. Hopefully I'll have some time to make
test cases for the other shadings.
Fixes #13372