-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize HTMLResult.{FAILURE, EMPTY}
lazily
#13497
Conversation
While these objects aren't exactly that big and/or complex, they are nonetheless *only* necessary for XFA documents. However, currently these objects are initialized *eagerly* for all PDF documents. By using the same pattern as elsewhere in the code-base, it's very easy to make these lazily initialized; so let's just do that instead :-)
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/06adc3d919f8185/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://3.101.106.178:8877/273e4db9845a371/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/06adc3d919f8185/output.txt Total script time: 3.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/273e4db9845a371/output.txt Total script time: 5.82 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1c93e4465838afd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/9cfc562427c848d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1c93e4465838afd/output.txt Total script time: 4.34 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/9cfc562427c848d/output.txt Total script time: 5.63 mins
|
Looks good; thanks! |
While these objects aren't exactly that big and/or complex, they are nonetheless only necessary for XFA documents.
However, currently these objects are initialized eagerly for all PDF documents. By using the same pattern as elsewhere in the code-base, it's very easy to make these lazily initialized; so let's just do that instead :-)