-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix position of highlighted all text. #13306
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d94cd777973dc10/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 2 Live output at: http://3.101.106.178:8877/b36d0029b0e1a87/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/b36d0029b0e1a87/output.txt Total script time: 29.61 mins
Image differences available at: http://3.101.106.178:8877/b36d0029b0e1a87/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d94cd777973dc10/output.txt Total script time: 60.00 mins |
Adds a new integration test to ensure we don't regress this again.
bec1e32
to
df521a0
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/6e91fa5b507b0cf/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e25cf45e279d137/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e25cf45e279d137/output.txt Total script time: 25.70 mins
Image differences available at: http://54.67.70.0:8877/e25cf45e279d137/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6e91fa5b507b0cf/output.txt Total script time: 29.99 mins
Image differences available at: http://3.101.106.178:8877/6e91fa5b507b0cf/reftest-analyzer.html#web=eq.log |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f35927319d32749/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/db349aa7bd6b48e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f35927319d32749/output.txt Total script time: 3.98 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/db349aa7bd6b48e/output.txt Total script time: 5.30 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e223335afb2b749/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/0514aa509d20522/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e223335afb2b749/output.txt Total script time: 3.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0514aa509d20522/output.txt Total script time: 5.30 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
When we insert extra spans for highlighting we want them to be positioned normally instead of absolute or relative. Fixes mozilla#13345.
Fix find highlighting regression from #13306.
Adds a new integration test to ensure we don't
regress this again.
Fixes #13292.