Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA DHL Form contains extra, blank pages #13583

Closed
JDziurlaj opened this issue Jun 18, 2021 · 0 comments · Fixed by #13598
Closed

XFA DHL Form contains extra, blank pages #13583

JDziurlaj opened this issue Jun 18, 2021 · 0 comments · Fixed by #13598
Labels
form-xfa

Comments

@JDziurlaj
Copy link

Attach (recommended) or Link to PDF file here:
https://www.dhl.com/content/dam/downloads/g0/express/emailship_page/globalpage/dhl_emailship_pdfclient_my_en.pdf

  • Web browser and its version: Firefox 89.0.1
  • Operating system and its version: Windows 10 10.0.19043.1052
  • PDF.js version: commit 5d251a3
  • Is a browser extension: No

Steps to reproduce the problem:

  1. Enable XFA support
  2. Open form

What is the expected behavior? (add screenshot)
First page loads
image

What went wrong? (add screenshot)
Extra blank pages load (pages 1, 3, 4, 7, 8)
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 21, 2021
@calixteman
XFA - Remove empty pages
a6d4d6b 
  - it aims to fix mozilla#13583;
  - because hidden subform and breakBefore some pages can be empty so remove them;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - fix a typo in radial gradient first argument.
@calixteman calixteman mentioned this issue Jun 21, 2021
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 26, 2021
@calixteman
XFA - Remove empty pages
a442f7e 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - fix a typo in radial gradient first argument.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 26, 2021
@calixteman
XFA - Remove empty pages
6916f7e 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - fix a typo in radial gradient first argument.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 29, 2021
@calixteman
XFA - Remove empty pages
6274145 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - fix a typo in radial gradient first argument.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 29, 2021
@calixteman
XFA - Remove empty pages
6fbcb19 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - fix a typo in radial gradient first argument.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 30, 2021
@calixteman
XFA - Remove empty pages
6db0023 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - handle correctly overflow in the same content area (bug 1717805, bug 1717668);
  - fix a typo in radial gradient first argument.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jun 30, 2021
@calixteman
XFA - Remove empty pages
ff440d1 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - handle correctly overflow in the same content area (bug 1717805, bug 1717668);
  - fix a typo in radial gradient first argument.
conghoang added a commit to conghoang/pdf.js that referenced this issue Jul 15, 2021
@conghoang
Merge commit '62808cb3c232ade45cc19495d68a70410daf1682'
ec49986 
* commit '62808cb3c232ade45cc19495d68a70410daf1682': (168 commits)
  Fix the remaining ESLint `operator-assignment` errors
  Enable the ESLint `operator-assignment` rule
  Remove the `version` field from the `package.json` file
  XFA - Don't use system font when a font is not embeded but there is a substitution   - always use a font coming from pdf.js when there is one: this way we don't use a system font which could looks wrong.
  [api-minor] Support accessing both the original and modified PDF fingerprint
  Don't attempt to structure clone unsupported types with workers disabled
  Replace `instanceof Object` with `typeof` checks
  XFA - Don't fill when the fill element is not visible (bug 1718735)
  XFA - Remove empty pages   - it aims to fix mozilla#13583;   - fix the switch to breakBefore target;   - force the layout of an unsplittable element on an empty page;   - don't fail when there is horizontal overflow (except in lr-tb);   - handle correctly overflow in the same content area (bug 1717805, bug 1717668);   - fix a typo in radial gradient first argument.
  Add PDFs from mozilla#1773 to the reftests
  XFA - Support non-embedded fonts without a Widths entry   - some pdf use some fonts which are not embedded or they don't have any width array or don't have any css info (e.g. for standard fonts or Arial).   - so add widths arrays for Liberation fonts in order to compute the ones for other fonts in using scale factors array.
  XFA - Choice list has no selected value by default
  XFA - Implement aspect property on image element   - it aims to fix issue mozilla#13634;   - move some img-related functions in test/drivers.js in order to have images in xfa reftests.
  XFA - Fix width of a container with lr-tb layout (bug 1718037)
  XFA - Remove quotes of font name in xhtml
  Add non-PRODUCTION/TESTING overflow `assert`s to various string helper-functions (issue 6759)
  XFA - Replace deprecated break element (bug 1718053)   - the break element has been deprecated in XFA 2.4 but some old documents can use it, so replace it with one (or more) of its possible substitutions:     - breakBefore;     - breakAfter;     - overflow.
  Add a `OnProgressParameters` typedef to reduce (some) duplication in `src/display/api.js`
  Use the `RefProxy` typedef in more JSDoc comments in `src/display/api.js`
  Update l10n files
  ...

# Conflicts:
#	src/display/canvas.js
bh213 pushed a commit to bh213/pdf.js that referenced this issue Jun 3, 2022
@calixteman @bh213
XFA - Remove empty pages
9ca8acb 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - handle correctly overflow in the same content area (bug 1717805, bug 1717668);
  - fix a typo in radial gradient first argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XFA - Remove empty pages calixteman/pdf.js
2 participants
@Snuffleupagus @JDziurlaj