Merge pull request #13465 from Snuffleupagus/misc-legacy-cleanup

Some `-es5`/`-legacy` renaming clean-up, and `deprecated` API options removal (PR 12978, PR 13207 follow-up)

docs/contents/getting_started/index.md

@@ -54,8 +54,8 @@ Before downloading PDF.js please take a moment to understand the different layer
       Includes the generic build of PDF.js and the viewer.
     </p>
     <span class="GROUP_CLASS">
-      <a type="button" class="btn btn-primary" href="https://github.com/mozilla/pdf.js/releases/download/vSTABLE_VERSION/pdfjs-STABLE_VERSION_LEGACY-dist.zip">Stable (vSTABLE_VERSION)</a>
-      <a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION_LEGACY-dist.zip">Beta (vBETA_VERSION)</a>
+      <a type="button" class="btn btn-primary" href="https://github.com/mozilla/pdf.js/releases/download/vSTABLE_VERSION/pdfjs-STABLE_VERSION-legacy-dist.zip">Stable (vSTABLE_VERSION)</a>
+      <a type="button" class="btn btn-warning HIDDEN_CLASS" href="https://github.com/mozilla/pdf.js/releases/download/vBETA_VERSION/pdfjs-BETA_VERSION-legacy-dist.zip">Beta (vBETA_VERSION)</a>
     </span>
   </div>
   <div class="col-md-4">

gulpfile.js

@@ -1907,20 +1907,6 @@ gulp.task("wintersmith", function (done) {
     }
     const { stableVersion, betaVersion } = config;
 
-    // Create appropriate file names for the legacy builds. This logic can be
-    // removed and/or simplified, once the stable version is past the cutoff.
-    const CUTOFF_VERSION = "2.7.570";
-    replaceInFile(
-      GH_PAGES_DIR + "/getting_started/index.html",
-      /STABLE_VERSION_LEGACY/g,
-      stableVersion + (stableVersion <= CUTOFF_VERSION ? "-es5" : "-legacy")
-    );
-    replaceInFile(
-      GH_PAGES_DIR + "/getting_started/index.html",
-      /BETA_VERSION_LEGACY/g,
-      betaVersion + (betaVersion <= CUTOFF_VERSION ? "-es5" : "-legacy")
-    );
-
     replaceInFile(
       GH_PAGES_DIR + "/getting_started/index.html",
       /STABLE_VERSION/g,

src/display/api.js

@@ -962,12 +962,6 @@ class PDFDocumentProxy {
    *   {Uint8Array} containing the full data of the saved document.
    */
   saveDocument() {
-    if (
-      (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) &&
-      arguments.length > 0
-    ) {
-      deprecated("saveDocument no longer accepts any options.");
-    }
     if (
       (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) &&
       this._transport.annotationStorage.size <= 0
@@ -1282,16 +1276,6 @@ class PDFPageProxy {
     includeAnnotationStorage = false,
     optionalContentConfigPromise = null,
   }) {
-    if (
-      (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) &&
-      arguments[0]?.annotationStorage !== undefined
-    ) {
-      deprecated(
-        "render no longer accepts an `annotationStorage` option, " +
-          "please use the `includeAnnotationStorage`-boolean instead."
-      );
-      includeAnnotationStorage ||= !!arguments[0].annotationStorage;
-    }
     if (this._stats) {
       this._stats.time("Overall");
     }