Re-order the names of the new pageColors options/preferences (PR 14…

…874 follow-up) Given that the new API-option is an Object named `pageColors`, with `background`/`foreground` keys, it occurred to be that it'd be slightly more consistent if the options/preferences names fully reflected that.
mozilla · May 8, 2022 · 84df28e · 84df28e
1 parent f8838eb
commit 84df28e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/web/app.js b/web/app.js
@@ -526,8 +526,8 @@ const PDFViewerApplication = {
       maxCanvasPixels: AppOptions.get("maxCanvasPixels"),
       enablePermissions: AppOptions.get("enablePermissions"),
       pageColors: {
-        background: AppOptions.get("pageBackgroundColor"),
-        foreground: AppOptions.get("pageForegroundColor"),
+        background: AppOptions.get("pageColorsBackground"),
+        foreground: AppOptions.get("pageColorsForeground"),
       },
     });
     pdfRenderingQueue.setViewer(this.pdfViewer);

diff --git a/web/app_options.js b/web/app_options.js
@@ -129,12 +129,12 @@ const defaultOptions = {
     compatibility: compatibilityParams.maxCanvasPixels,
     kind: OptionKind.VIEWER,
   },
-  pageBackgroundColor: {
+  pageColorsBackground: {
     /** @type {string} */
     value: "Canvas",
     kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
   },
-  pageForegroundColor: {
+  pageColorsForeground: {
     /** @type {string} */
     value: "CanvasText",
     kind: OptionKind.VIEWER + OptionKind.PREFERENCE,