Split project into two crates mp4parse and mp4parse_capi (fixes #18) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased and ready to be merged. :) |
| build = "build.rs" | ||
|
|
||
| [dependencies] | ||
| "mp4parse" = {path = "../mp4parse"} |
There was a problem hiding this comment.
So the idea would be to rewrite this to a version number every time I want to publish a new version of the crates?
At least cargo publish complains, so it's not possible to forget.
There was a problem hiding this comment.
What do you mean it complains?
There was a problem hiding this comment.
$ cargo publish
Updating registry `https://github.com/rust-lang/crates.io-index`
error: all path dependencies must have a version specified when publishing.
dependency `mp4parse` does not specify a version
I filed rust-lang/cargo#3060 to add the same check to cargo package.
There was a problem hiding this comment.
Oh right! https://github.com/serde-rs/serde/blob/master/serde_codegen/Cargo.toml#L36
This is not a bug and it indeed needs a version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.