feat(next): Clean up artifacts from checkout process on checkout failure #18316

david1alvarez · 2025-02-04T23:32:13Z

Because

As the user processes through the checkout process for a subscription, we create business objects to represent their subscription and the stakeholders. If the subscription fails, the artifacts need to be cleaned up.

This pull request

Adds additional logic to the cart service wrapWithCartCatch method to clean up defunct artifacts.

Issue that this pull request solves

Closes: #FXA-10628

Checklist

Put an x in the boxes that apply

My commit is GPG signed.
If applicable, I have modified or added tests which pass locally.
I have added necessary documentation (if appropriate).
I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

libs/payments/cart/src/lib/cart.service.ts

julianpoy · 2025-02-07T19:33:26Z

libs/payments/cart/src/lib/cart.service.ts

+            }
+          } catch (e) {
+            // swallow the error to allow cancellation of the subscription
+            console.error(e);


This should probably be a sentry log -- console logs really don't go anywhere

Because: * As the user processes through the checkout process for a subscription, we create business objects to represent their subscription and the stakeholders. If the subscription fails, the artifacts need to be cleaned up. This commit: * Adds additional logic to the cart service wrapWithCartCatch method to clean up defunct artifacts. Closes #FXA-10628

david1alvarez requested a review from a team as a code owner February 4, 2025 23:32

david1alvarez force-pushed the FXA-10628 branch from 1c39a63 to 02724b8 Compare February 4, 2025 23:32

david1alvarez requested a review from julianpoy February 5, 2025 18:34