Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): account for snake case of metrics context query params #18315

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(metrics): account for snake case of metrics context query params #18315

merged 1 commit into from
Feb 5, 2025

Conversation

chenba
Copy link
Contributor

@chenba chenba commented Feb 4, 2025

No description provided.

@chenba chenba requested a review from a team as a code owner February 4, 2025 22:51
jonalmeida
jonalmeida approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused by the camel casing recently when working on the query params banner. This seems like a safe way to handle it!

@chenba chenba merged commit 16deb2e into main Feb 5, 2025
23 checks passed
@chenba chenba deleted the fxa-metric-snakes branch February 5, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonalmeida jonalmeida jonalmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenba @jonalmeida