This repository has been archived by the owner on Oct 3, 2018. It is now read-only.
DB cleanup in preparation of e10s support #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Breaks out metadata into it's own columns/tables - Stores value type and kind in data table - Adds process name to data table
- Always report kind and unit - Don't convert to strings, just report the integer value
Removes intermediate conversion step.
- Process and checkpoint names are properly inserted - All new columns in benchtester_data are filled
Uses new DB fields. Currently only handles the Main process and ignores the 'kind' field.
|
I checked to make sure we're not exploding the db size, this seems to have reduced the size for the single process case, slightly increased for the multiprocess case (which makes sense as there's more data).
Also it looks like total insert time of test data into the DB increased from ~550ms to ~800ms. |
Based on the original update_database.py script.
|
Added the update script. If things scale it looks like it will take ~4s per test, so something like 80 minutes for the month of January. |
This was referenced Feb 27, 2015
Closed
|
r+ from me, not that I had much to add. |
EricRahm
added a commit
that referenced
this pull request
Mar 26, 2015
DB cleanup in preparation of e10s support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds further DB normalization (process table, checkpoint table), removes the metadata column, adds columns for process, checkpoint, iteration and kind.
create_graph_json.pyis updated to handled the new DB format, but still only generates data for the main process.@Nephyrin can you take a look?