Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup request-tls for remote loading of manifests #5047

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Jul 18, 2022

This PR fixes an issue with fetching of remote files via reqwest and tls.

It also introduces a fetch command to the nimbus-fml command line.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ac: android-components-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@jhugman jhugman requested review from tarikeshaq and travis79 July 18, 2022 13:07
@codecov-commenter
Copy link

Codecov Report

Merging #5047 (005287a) into main (8ae6b57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5047   +/-   ##
=======================================
  Coverage   38.49%   38.49%           
=======================================
  Files         168      168           
  Lines       12382    12382           
=======================================
  Hits         4766     4766           
  Misses       7616     7616           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae6b57...005287a. Read the comment docs.

@jhugman jhugman merged commit d72ce6f into main Jul 18, 2022
@jhugman jhugman deleted the jhugman/add-fetch-command-debugging-reqwest-tls branch July 18, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants