delete_visits_between now deletes history metadata too

[tarikeshaq]

Part of https://mozilla-hub.atlassian.net/browse/SYNC-3229, second part being exposing this API to iOS (which will happen in #4989

Changes delete_visits_between to now also delete history metadata.

The deletion of the history metadata is not dependent on the deletion of the visits - want feedback on that, the idea is that

• it's OK if we want to delete history metadata without there being any visits (the iOS case)
• If the whole places entry is deleted with the visit, we are OK since deletes cascade
• I thought it should be OK if we delete a history metadata entry, while the associated visit is still alive (given that the history metadata was recorded within the requested deletion frame)

I'm still getting familiar with this p

Pull Request checklist

• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ac: android-components-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

[codecov-commenter]

Codecov Report

Merging #5046 (094ccb8) into main (34544f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5046   +/-   ##
=======================================
  Coverage   38.49%   38.49%           
=======================================
  Files         168      168           
  Lines       12382    12382           
=======================================
  Hits         4766     4766           
  Misses       7616     7616           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34544f4...094ccb8. Read the comment docs.

[mhammond]

Looks great! Should we get a followup so all the delete functions also delete metadata? I can't see a good reason for some to do so and others not doing it.