CI tests for make check to prevent breakage to our local dev: #22928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15229
Description
Adds additional test coverage for local dev setup via a new workflow
test_check
which runs make up and make check on a variety of configurations.Additionally, this adds more tests to apps.py to cover various assertions about our dev container.
Context
This test ensures future regressions are caught by running our local dev setup in a number of different configurations and asserting the containers are up and running smoothely.
Testing
You can test the configuration is solid by installing npm depenencies on the host (to run the test command)
Then run the test command
shared volume missing from '.services.olympia_volumes.volumes'
'olympia_volumes' missing from dependency list of service using shared volume
(optional) Duplicate bind mount does not raise
.:/data/olympia
to multiple services.Expect the tests to pass as bind mounts can be freely shared without causing race conditions
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.