This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Change CI/CD sequence for v1.38.5 #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnbus
reviewed
Apr 10, 2019
| @@ -46,7 +46,8 @@ RUN mkdir -p /opt/mozdef/envs/meteor/mozdef | |||
| RUN if [ "${METEOR_BUILD}" = "YES" ]; then \ | |||
| cd /opt/mozdef/envs/mozdef/meteor && \ | |||
| meteor npm install && \ | |||
| meteor build --server localhost:3002 --directory /opt/mozdef/envs/meteor/mozdef && \ | |||
| echo "Starting meteor build" && \ | |||
| time meteor build --server localhost:3002 --directory /opt/mozdef/envs/meteor/mozdef && \ | |||
There was a problem hiding this comment.
Do we still want to include this time command? Or was this for debugging purposes?
There was a problem hiding this comment.
I'd hoped to include it as it's useful information during the build to show what just happened for the last 3 minutes. I looked into how to get meteor build to output some kind of progress our output and had no luck. So yes, I think we should keep the time in. Is there any downside?
There was a problem hiding this comment.
I'm fine with keeping it in, just curious if it was intentional or not.
pwnbus
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the CI/CD order to now build docker images in CodeBuild, upload them
to DockerHub and then pull them down in the packer instance. Updated docs.
I confirmed this one works in a branch and built a new stack and updated an existing stack with the resulting artifacts.