This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Adding open and close abstraction for managing indexes #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnbus
previously requested changes
Feb 27, 2019
added 6 commits
March 12, 2019 16:19
…lose. Change method in which we determine if the index should be closed.
Needs a fresh review after code changes.
pwnbus
suggested changes
Mar 21, 2019
…ge, correcting method call name, correcting function name in esclient
|
This was tested to work in my dev environment, all requested changes have been implemented. |
added 2 commits
April 5, 2019 12:23
pwnbus
suggested changes
Apr 9, 2019
… to requirements.txt
pwnbus
approved these changes
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.