Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external scorer file and documentation and flag references #3192

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Remove external scorer file and documentation and flag references #3192

merged 2 commits into from
Jul 28, 2020

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Jul 27, 2020

No description provided.

@reuben reuben requested a review from kdavis-mozilla July 28, 2020 08:32
kdavis-mozilla
kdavis-mozilla approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit is that in Program.cs there is still a ref to kenlm.scorer even though it, as far as I can see, it is never used.

@reuben
Copy link
Contributor Author

reuben commented Jul 28, 2020

It's just a default path if one is not specified.

@reuben reuben merged commit c1fd93a into master Jul 28, 2020
@reuben reuben deleted the remove-scorer branch July 28, 2020 09:15
@kdavis-mozilla
Copy link
Contributor

It's just a default path if one is not specified.

I agree, but the null check it's surrounded in makes sure it's never used. So it serves no purpose as far as I can see.

@kdavis-mozilla kdavis-mozilla mentioned this pull request Jul 28, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdavis-mozilla kdavis-mozilla kdavis-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuben @kdavis-mozilla