Build and publish iOS framework in GitHub release files #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
386bb80 to
47685f0
Compare
lissyx
reviewed
Jul 22, 2020
|
|
||
| package_libdeepspeech_as_zip "libdeepspeech.zip" | ||
|
|
||
| case $arch in |
There was a problem hiding this comment.
nit: do we really need the case here? I feel like we could just have
${TAR} -cf - \
-C ${DS_ROOT_TASK}/DeepSpeech/ds/native_client/swift/DerivedData/Build/Products/Release-*/ deepspeech_ios.framework \
| ${XZ} > "${TASKCLUSTER_ARTIFACTS}/deepspeech_ios.framework.${arch}.tar.xz"
lissyx
reviewed
Jul 22, 2020
| arch=$1 | ||
| cp ${DS_TFDIR}/bazel-bin/native_client/libdeepspeech.so ${DS_DSDIR}/native_client/swift/libdeepspeech.so | ||
| cd ${DS_DSDIR}/native_client/swift | ||
| case $arch in |
There was a problem hiding this comment.
nit: I think we could just have the case set a few variables like the SDK variant and have one xcodebuild call after:
case $arch in
"--x86_64")
iosSdk="iphonesimulator"
;;
"--arm64")
iosSdk="iphoneos"
;;
esac
xcodebuild -workspace deepspeech_ios.xcworkspace -scheme deepspeech_ios_test -configuration Release -arch ${arch} -sdk ${iosSdk} -derivedDataPath DerivedData CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO
lissyx
approved these changes
Jul 22, 2020
lissyx
reviewed
Jul 22, 2020
taskcluster/ios-package.sh
Outdated
| ;; | ||
| esac | ||
|
|
||
| ${TAR} -cf - \ | ||
| -C ${DS_ROOT_TASK}/DeepSpeech/ds/native_client/swift/DerivedData/Build/Products/Release-iphonesimulator/ deepspeech_ios.framework \ |
There was a problem hiding this comment.
Aren't you going to have an issue here with Release-iphonesimulator ? ARM64 builds seems to end up in Release-iphoneos ?
fa1d2f4 to
844b375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.