-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS support #3150
Merged
iOS support #3150
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3ce07af
Add TensorFlow iOS tasks
reuben c85f95f
Add DeepSpeech iOS tasks
reuben 4ca0f94
client.cc iOS build
reuben a1aa873
Embed bitcode when linking
reuben a274c26
Add Swift wrapper framework
reuben f7c5066
Checkout fixed formulas commit in tf_tc-brew.sh
reuben e8d642b
Bump TensorFlow to remove usage of -z linker keyword on iOS
reuben 6c38d56
Use submodule TF tc-vars.sh
reuben 2f568e7
Don't use BAZEL_OPT_FLAGS in iOS builds
reuben aa8e9b0
Use correct build flags for ARM64 vs x86_64
reuben f0f4b0d
Remove even more bazel flags
reuben be43b3f
Bump caches for artifacts rebuilt on new worker
reuben de7a249
Fix linker issues during tests with new workers
reuben 5e5db17
Address review comments
reuben d9dac13
Clean up tf_tc-build.sh
reuben 2672878
Add docs to Swift bindings and missing methods
reuben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice documenting. Do you know if we are ready to run swift-backed doc against readthedocs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately there is no Swift support for our Sphinx version. So it'll be a bit more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think it's supported by Doxygen, so we can use the existing support for that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked for that too and couldn't find any Doxygen support. Do you have a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I just saw a few people here and there that seemed to have it processing, as well as some apple github like https://github.com/apple/swift/blob/master/docs/doxygen.header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is for Doxygen docs of the Swift compiler, which is implemented in C++.