Add NET Framework targets #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, of course missing frameworks 4.5 and 4.7 |
|
LGTM- |
lissyx
approved these changes
Mar 15, 2019
|
@carlfm01 Okay, next time we should run PR, build seems okay with v4.5, v4.6 and v4.7 https://taskcluster-artifacts.net/dpq6NZBAQYaD43hLAzwZPA/0/public/logs/live_backing.log but packaging step seems to fail, can you have a look @carlfm01 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .NET framework targets to the Nuget package, adding .NET Frameworks client for 4.5,4.6 and 4.7, not ready yet, maybe will include the fix for the .so not being moved to the target directory.