Jump through a bunch of hoops to limit the number of times we retry d…

…uring tests

components/utilities.py

@@ -144,12 +144,15 @@ def decorate(func):
 # Retry calling a function `times` times, sleeping between each tries, with an exponential backoff
 # This is to be used on API calls, that are likely to fail
 
+RETRY_TIMES = 10
 
-def retry(_func=None, *, times=10, sleep_s=1, exp=2):
+
+def retry(_func=None, *, sleep_s=1, exp=2):
     def decorator_retry(func):
         @functools.wraps(func)
         def wrapper_retry(*args, **kwargs):
-            retries_try = times
+            global RETRY_TIMES
+            retries_try = RETRY_TIMES
             sleep_duration = sleep_s
             while retries_try > 0:
                 try:

tests/functionality_all_platforms.py

@@ -16,6 +16,9 @@
 
 sys.path.append(".")
 sys.path.append("..")
+import components.utilities
+components.utilities.RETRY_TIMES = 2
+
 from automation import Updatebot
 
 from components.utilities import Struct, raise_, AssertFalse

tests/functionality_commitalert.py

@@ -12,6 +12,9 @@
 
 sys.path.append(".")
 sys.path.append("..")
+import components.utilities
+components.utilities.RETRY_TIMES = 2
+
 from automation import Updatebot
 
 from components.utilities import Struct, NeverUseMeClass

tests/functionality_two_platforms.py

@@ -16,6 +16,9 @@
 
 sys.path.append(".")
 sys.path.append("..")
+import components.utilities
+components.utilities.RETRY_TIMES = 2
+
 from automation import Updatebot
 
 from components.utilities import Struct, raise_, AssertFalse
@@ -34,6 +37,7 @@
 from tests.mock_treeherder_server import MockTreeherderServerFactory, TYPE_HEALTH
 from tests.database import transform_db_config_to_tmp_db
 
+
 try:
     from localconfig import localconfig
 except ImportError: