Fix pushing a preset to try.

The preset argument has to come right after --preset
mozilla-services · Oct 28, 2024 · 9da81a8 · 9da81a8
1 parent 96fe6b9
commit 9da81a8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/apis/taskcluster.py b/apis/taskcluster.py
@@ -160,7 +160,7 @@ def submit_to_try(self, library, platform_filter, recursed=0):
             platform_filter_args = ["--tasks-regex", platform_filter]
 
         if library.try_preset:
-            try_arguments = ["./mach", "try", "--update", "--preset", "--push-to-vcs", library.try_preset]
+            try_arguments = ["./mach", "try", "--update", "--push-to-vcs", "--preset", library.try_preset]
         elif library.fuzzy_query or library.fuzzy_paths:
             try_arguments = ["./mach", "try", "fuzzy", "--push-to-vcs", "--update"]
             if library.fuzzy_query:

diff --git a/tests/functionality_all_platforms.py b/tests/functionality_all_platforms.py
@@ -59,7 +59,7 @@ def COMMAND_MAPPINGS(expected_values, command_callbacks):
     ret = SHARED_COMMAND_MAPPINGS(expected_values, command_callbacks)
     ret["./mach try auto"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revision_id()))
     ret["./mach try fuzzy"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revision_id(), False))
-    ret["./mach try --update --preset"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revision_id(), False))
+    ret["./mach try --update --push-to-vcs --preset"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revision_id(), False))
     return ret
 
 

diff --git a/tests/functionality_two_platforms.py b/tests/functionality_two_platforms.py
@@ -60,7 +60,7 @@ def COMMAND_MAPPINGS(expected_values, command_callbacks):
     ret = SHARED_COMMAND_MAPPINGS(expected_values, command_callbacks)
     ret["./mach try auto --push-to-vcs --tasks-regex "] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revisions_func()[0]))
     ret["./mach try fuzzy"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revisions_func()[0], False))
-    ret["./mach try --update --preset"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revisions_func()[0], False))
+    ret["./mach try --update --push-to-vcs --preset"] = command_callbacks.get('try_submit', lambda: TRY_OUTPUT(expected_values.try_revisions_func()[0], False))
     if len(expected_values.try_revisions_func()) > 1:
         ret['./mach try auto --push-to-vcs --tasks-regex-exclude '] = lambda: TRY_OUTPUT(expected_values.try_revisions_func()[1])
     return ret