Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #838: check to create a task #876

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Fix #838: check to create a task #876

merged 5 commits into from
Sep 2, 2021

Conversation

leplatrem
Copy link
Contributor

A simple atomic test to cover the task creation part from #838

@leplatrem leplatrem requested a review from jwhitlock September 1, 2021 14:45
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leplatrem! I think the shell command needs adjustment, and some imports removed to make the linter happy.

checks/taskcluster/create_task.py Outdated Show resolved Hide resolved
checks/taskcluster/create_task.py Outdated Show resolved Hide resolved
checks/taskcluster/create_task.py Outdated Show resolved Hide resolved
poucave/config.py Show resolved Hide resolved
leplatrem added a commit that referenced this pull request Sep 2, 2021
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leplatrem leplatrem merged commit 69066d3 into main Sep 2, 2021
@leplatrem leplatrem deleted the 838-create-task branch September 2, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants