Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'period_sampling_seconds' param instead of hard-coded 600 seconds #1486

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add 'period_sampling_seconds' param instead of hard-coded 600 seconds #1486

merged 1 commit into from
Sep 10, 2024

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Sep 10, 2024 •
edited
Loading

This parameter was only available in checks/remotesettings/uptake_spikes.py

@leplatrem leplatrem added the enhancement New feature or request label Sep 10, 2024
@leplatrem leplatrem requested a review from a team as a code owner September 10, 2024 11:25
@leplatrem leplatrem marked this pull request as draft September 10, 2024 11:27
@leplatrem leplatrem force-pushed the period-sampling-configurable branch from c725a03 to 9f17a4a Compare September 10, 2024 11:31
@leplatrem leplatrem marked this pull request as ready for review September 10, 2024 11:31
@leplatrem leplatrem merged commit 60971c2 into main Sep 10, 2024
4 checks passed
@leplatrem leplatrem deleted the period-sampling-configurable branch September 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @grahamalama