Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1320: fix handling of futures in work-in-progress check #1349

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Nov 22, 2023

This PR:

  • fixes a bug where signed collections would show up in info (because zipping two lists of different sizes)
  • does not compare records if status is to-review (no need)
  • does not fetch records in parallel anymore (since old wip collections are rare, no need)

@leplatrem leplatrem requested a review from a team as a code owner November 22, 2023 13:00
@leplatrem leplatrem added the bug Something isn't working label Nov 22, 2023
@alexcottner
Copy link
Contributor

alexcottner commented Nov 22, 2023

Longer term - the kinto API should be flexible enough to return exactly the data that clients need. This app really shouldn't need to have business logic in it. If clients need to do further filtering of data that feels like a miss in our API tier.

@leplatrem leplatrem merged commit 1830a56 into main Nov 23, 2023
4 of 5 checks passed
@leplatrem leplatrem deleted the 1320-fix-wip-signed branch November 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants