Fix #811 Document use_test_transactions and expose it using an environment variable #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally, when running cargo test, the test transaction data is discarded. This makes debugging test state difficult. There is a use_test_transactions setting that can be overridden, but the tests then re-override your decision to force them on.
This branch exposes the variable using the SYNC_DATABASE_USE_TEST_TRANSACTIONS environment variable.
Also, it documents how to use this feature.
Testing
All tests should pass.
Running
SYNC_DATABASE_USE_TEST_TRANSACTIONS=false cargo test commitshould leave data in the mysql database.Running
cargo test commitshould not leave anything in the database, as usual.Issue(s)
Closes #811