Log product, os, and lang

[willdurand]

Fixes #219

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (e01f8ce) to head (0ef7816).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   84.66%   84.80%   +0.13%     
==========================================
  Files          15       15              
  Lines         874      882       +8     
==========================================
+ Hits          740      748       +8     
  Misses         92       92              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bhearsum]

The things that are here seem fine, but just to go over everything that was requested:

country (or a T/F indicating “came from EU Banner country”)

This seems like it would be possible to add, but not trivially (you'd need to incorporate a geoip library, and then keep that up to date?).

OS, OS version
Downloading browser (if available)

OS of the download is covered here; but not the other parts.

Can/should User Agent, or parts of it be logged? IIRC OS Version is not reliable in User Agent strings, but I think it would cover OS & Browser (for cases where the user agent isn't a lie, anyways).

Channel, locale, and build of downloaded installer (if available)

locale is directly covered here, but not the other two. Channel could be inferred (I think) by looking at product. I'm assuming build is supposed to be the version number being requested, which seems like it could be covered here?

[willdurand]

Right, the initial issue hasn't been updated but the data review request only mentions os, product and locale, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1896957. That's because "we only want what's currently easy to add" (quoted from the issue).

We'll probably want to update the issue.