bug-1912979: fix rerererereprocessing problem in local dev env #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to set the ack_deadline_seconds otherwise it defaults to 10 seconds which isn't long enough and causes crash ids to get read again. And again. And again. And again again.
willkg
commented
Aug 13, 2024
| subscriber.create_subscription( | ||
| name=subscription_path, | ||
| topic=topic_path, | ||
| ack_deadline_seconds=600, |
There was a problem hiding this comment.
600 is the number we use in stage and prod.
relud
approved these changes
Aug 13, 2024
willkg
added a commit
to mozilla-services/obs-common
that referenced
this pull request
Dec 6, 2024
This re-implements the fix from mozilla-services/socorro#6689
willkg
added a commit
to mozilla-services/obs-common
that referenced
this pull request
Dec 6, 2024
This re-implements the fix from mozilla-services/socorro#6689 Before this fix, the ack_deadline_timeout is 10 seconds which isn't long enough for the Socorro processor to process a crash report which causes the crash id to be available in the subscription again which causes the crash report to get reprocessed over and over again.
willkg
added a commit
to mozilla-services/obs-common
that referenced
this pull request
Dec 6, 2024
This re-implements the fix from mozilla-services/socorro#6689 Before this fix, the ack_deadline_timeout is 10 seconds which isn't long enough for the Socorro processor to process a crash report which causes the crash id to be available in the subscription again which causes the crash report to get reprocessed over and over again.
github-merge-queue bot
pushed a commit
to mozilla-services/obs-common
that referenced
this pull request
Dec 6, 2024
This re-implements the fix from mozilla-services/socorro#6689 Before this fix, the ack_deadline_timeout is 10 seconds which isn't long enough for the Socorro processor to process a crash report which causes the crash id to be available in the subscription again which causes the crash report to get reprocessed over and over again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set the ack_deadline_seconds otherwise it defaults to 10 seconds which isn't long enough and causes crash ids to get read again. And again. And again. And again again.
This only affects the local dev environment, so I'm putting it up for review for reals.