Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for #16: check duplicate entities in json_verify #19

Merged
merged 5 commits into from
Aug 25, 2016
Merged

for #16: check duplicate entities in json_verify #19

merged 5 commits into from
Aug 25, 2016

Conversation

groovecoder
Copy link
Contributor

Implemented the logic and found existing duplicates:

disconnect-entitylist.json : invalid
        Dupe: Dupe host: tumblr.com      in line 9363
        Dupe: Dupe host: buzzcity.com    in line 2014
        Dupe: Dupe host: adonnetwork.com         in line 925
        Dupe: Dupe host: i-behavior.com  in line 3716
        Dupe: Dupe host: flurry.com      in line 3280
        Dupe: Dupe host: tumblr.com      in line 9366
        Dupe: Dupe host: buzzcity.com    in line 2017
        Dupe: Dupe host: adonnetwork.com         in line 929
        Dupe: Dupe host: i-behavior.com  in line 3720

What should we do with the existing duplicates?

@fmarier fmarier mentioned this pull request Aug 23, 2016
Closed
groovecoder and others added 5 commits August 25, 2016 10:25
@groovecoder
host_type is more accurate variable name
1e0b263
@groovecoder
for #16: check duplicate entities in json_verify
7387ebb
@groovecoder
Remove duplicate entries for companies acquired by others
70c8fd4
@groovecoder
Remove misclassified duplicate entry
53a2775 
i-behavior.com claims to be part of the KBM Group, while quisma.com
is part of GroupM Connect. These look like separate organizations
so they should be kept as separate entities.
@groovecoder
Remove duplicate entry and obsolete one
b8105c1 
adonnetworks.com also appears in Prime Visibility (which matches the
staement in the footer of that website: "a PV Media Group company"),
but the other domain, dashboardad.net, doesn't appear to be in use
anymore. None of the hostnames that can be found on Google resolve
anymore.
@groovecoder groovecoder force-pushed the unique-entity-hosts-16 branch from 2799095 to b8105c1 Compare August 25, 2016 15:25
groovecoder
groovecoder reviewed Aug 25, 2016
View reviewed changes
disconnect-entitylist.json
"AdOn Network": {
"properties": [
"adonnetwork.com",
"dashboardad.net"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ... I don't see dashboardad.net in the entity list at all anymore? Did this get lost?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the third commit: b8105c1

@groovecoder groovecoder merged commit 12e0ffb into master Aug 25, 2016
@groovecoder groovecoder deleted the unique-entity-hosts-16 branch August 25, 2016 21:59
@groovecoder groovecoder mentioned this pull request Sep 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fmarier fmarier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groovecoder @fmarier