Remove urlwait in favor of waitfor #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c022861 to
79685a6
Compare
willkg
reviewed
Nov 4, 2024
obs_common/waitfor.py
Outdated
| @@ -28,6 +46,9 @@ def main(args=None): | |||
| ) | |||
| parser.add_argument("--verbose", action="store_true") | |||
| parser.add_argument("--timeout", type=int, default=15, help="Wait timeout") | |||
There was a problem hiding this comment.
I documented this poorly--it's very confusing. What's really going on is that waitfor will keep attempting with a 5-second timeout until this timeout parameter is exceeded.
At some point, we should either rename this argument or fix the documentation. We don't have to do that in this PR.
There was a problem hiding this comment.
changed the --timeout help string to "Seconds after which to stop retrying. This is separate from the timeout for individual attempts, which is 5 seconds."
willkg
requested changes
Nov 5, 2024
willkg
approved these changes
Nov 5, 2024
| default=15, | ||
| help=( | ||
| "Seconds after which to stop retrying. This is separate from the timeout " | ||
| "for individual attempts, which is 5 seconds." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested in #28 (comment)
adds support for non-http services based on https://github.com/pmac/urlwait/blob/master/urlwait.py#L89 so that socorro and tecken can also drop urlwait
also adds missing
make updatereqscommand to match other obs team reposfixes #38