Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISCO-3183 Consolidate manifest configs #772

Merged
merged 1 commit into from
Jan 29, 2025
Merged

DISCO-3183 Consolidate manifest configs #772

merged 1 commit into from
Jan 29, 2025

Conversation

gruberb
Copy link
Member

@gruberb gruberb commented Jan 29, 2025 •
edited
Loading

References

JIRA: DISCO-3183

Description

TopPicks and Manifest are using the same bucket and the same file.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@gruberb gruberb requested a review from a team January 29, 2025 12:48
misaniwere
misaniwere approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@misaniwere misaniwere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

merino/configs/__init__.py Show resolved Hide resolved
merino/configs/default.toml Show resolved Hide resolved
@gruberb gruberb force-pushed the DISCO-3183-consolidate-settings branch from adf0031 to ae86016 Compare January 29, 2025 15:15
@gruberb gruberb added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 1972155 Jan 29, 2025
4 of 7 checks passed
@gruberb gruberb deleted the DISCO-3183-consolidate-settings branch January 29, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaniwere misaniwere misaniwere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruberb @misaniwere