forked from dora-team/fourkeys
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service column to BigQuery views 📈 #7
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8c6c01e
Reformat SQL in changes.sql
hackebrot 841a2db
Add service field for service repo to changes.sql
hackebrot 15f40a9
Delete GitLab query logic from deployments.sql
hackebrot 8b09cc5
Delete Tekton query logic from deployments.sql
hackebrot c3c7fec
Reformat SQL in deployments.sql
hackebrot 196727f
Add service field for service repo to deployments.sql
hackebrot 7dde90d
Delete CircleCI query logic from deployments.sql
hackebrot ad67e5c
Update deployments.sql to join changes also on service
hackebrot 5765a38
Delete GitLab query logic from incidents.sql
hackebrot 73bdc9e
Reformat SQL in incidents.sql
hackebrot da5102f
Add service field to incidents.sql
hackebrot e7b6bee
Fix comment in changes.sql
hackebrot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that these will match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these won't match. It will require the new
services
table to join service identifiers across platforms.But the
source
field tells us what the context is forservice
, so we can perform that lookup.