Skip to content

Commit

Permalink
Drop support for Python 3.8 (#158)
Browse files Browse the repository at this point in the history
  • Loading branch information
willkg committed Oct 17, 2024
1 parent 71e58eb commit 92e67dd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']

name: Python ${{ matrix.python-version}}
steps:
Expand Down
1 change: 1 addition & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ History
Changes:

* Transfered repository from willkg to mozilla-services.
* Drop support for Python 3.8. (#158)


2.0.0 (April 12th, 2024)
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ clean: ## Clean build artifacts

.PHONY: format
format: ## Format files
tox exec -e py38-lint -- ruff format
tox exec -e py39-lint -- ruff format

.PHONY: lint
lint: ## Lint files
tox -e py38-lint
tox -e py39-lint

.PHONY: test
test: ## Run tests
Expand Down
14 changes: 6 additions & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ readme = "README.rst"
keywords = ["socorro"]
authors = [{name = "Will Kahn-Greene"}]
license = {text = "MPLv2"}
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = [
"click",
"more_itertools",
Expand All @@ -21,7 +21,6 @@ classifiers = [
"License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)",
"Natural Language :: English",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -62,7 +61,7 @@ build-backend = "setuptools.build_meta"


[tool.ruff]
target-version = "py38"
target-version = "py39"
src = ["src"]
line-length = 88

Expand All @@ -83,16 +82,14 @@ legacy_tox_ini = """
[tox]
isolated_build = True
envlist =
py38
py38-lint
py39
py39-lint
py310
py311
py312
[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand All @@ -102,8 +99,9 @@ python =
extras = dev
commands = pytest {posargs}
[testenv:py38-lint]
basepython = python3.8
[testenv:py39-lint]
allowlist_externals = ruff
basepython = python3.9
changedir = {toxinidir}
commands =
ruff format --check src tests
Expand Down

0 comments on commit 92e67dd

Please sign in to comment.