Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use MozLogging, re-enable metrics #46

Merged
merged 1 commit into from
Oct 29, 2018
Merged

feat: Use MozLogging, re-enable metrics #46

merged 1 commit into from
Oct 29, 2018

Conversation

jrconlin
Copy link
Member

  • Optional "human_logs" for non-json logging
  • cargo update
  • drop logging actor in favor of straight calls; use tags better

Issue #34, #15

@jrconlin jrconlin requested review from rfk and pjenvey and removed request for rfk October 26, 2018 21:41
pjenvey
pjenvey requested changes Oct 29, 2018
View reviewed changes
channelserver/src/logging.rs Outdated
@@ -40,6 +42,26 @@ impl Debug for ErrorLevel {

impl MozLogger {
pub fn new() -> Self {
let decorator = slog_term::TermDecorator::new().build();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused

@jrconlin
feat: Use MozLogging, re-enable metrics
caf804b 
* Optional "human_logs" for non-json logging
* cargo update
* drop logging actor in favor of straight calls; use tags better

Issue #34, #15
@jrconlin jrconlin mentioned this pull request Oct 29, 2018
Closed
2 tasks
pjenvey
pjenvey approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer 👍. you could probably even add a Deref for MozLogger to return the inner slog Logger, so you would only have to do info(*state.log,... vs log.log

@jrconlin
Copy link
Member Author

Agree about the Deref, but will save that for later. I may revisit how the WSChannelState is currently done.

@jrconlin jrconlin merged commit c38039d into master Oct 29, 2018
@jrconlin jrconlin deleted the feat/34-15 branch October 29, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjenvey pjenvey pjenvey approved these changes

@rfk rfk Awaiting requested review from rfk

Assignees
No one assigned
Labels
waffle:review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrconlin @pjenvey @shane-tomlinson