bug: Address insecure sub header fetch. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When insecurely getting the `sub` for tracking and errors, we were not properly decoding. This was resulting in a VAPID error being generated. This should not impact processing, but was generating a lot of logging messages. * FCM would reject TTLS > that 4 weeks, which is less than our 30 day max. Added a specific filter for that. * fixed some spelling mistakes. Closes: SYNC-4514
taddes
requested changes
Nov 20, 2024
autopush-common/src/lib.rs
Outdated
| @@ -44,7 +44,10 @@ pub mod util; | |||
| /// "abandoned" and any router info assigned to a User Agent that has not contacted | |||
| /// Autopush in 60 days can be discarded. | |||
| /// | |||
| const ONE_DAY: u64 = 24 * 60 * 60; | |||
There was a problem hiding this comment.
It's pretty clear from the surrounding comments that it's seconds, but maybe just for sanity: a docstring stating this is in seconds, opposed to renaming something like ONE_DAY_IN_SECONDS, just like the other consts below.
pjenvey
requested changes
Nov 20, 2024
pjenvey
requested changes
Nov 21, 2024
pjenvey
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When insecurely getting the
subfor tracking and errors, we were notproperly decoding. This was resulting in a VAPID error being generated.
This should not impact processing, but was generating a lot of logging
messages.
FCM would reject TTLS > that 4 weeks, which is less than
our 30 day max. Added a specific filter for that.
fixed some spelling mistakes.
Closes: SYNC-4514