Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no lookup/notify of nodes after storing unacked messages on disconnects #58

Closed
pjenvey opened this issue Aug 7, 2018 · 0 comments
Closed

no lookup/notify of nodes after storing unacked messages on disconnects #58

pjenvey opened this issue Aug 7, 2018 · 0 comments
Assignees
@bbangert
Labels
enhancement New feature or request p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Aug 7, 2018

I don't recall us intentionally omitting this from autopush-rs:

https://github.com/mozilla-services/autopush/blob/5a2c3d0/autopush/websocket.py#L591

When storing unacked messages due to a client disconnecting, we also check if they've already reconnected to another node and if so notify them to check storage
@pjenvey pjenvey added enhancement New feature or request p1 labels Aug 7, 2018
bbangert added a commit that referenced this issue Aug 24, 2018
@bbangert
feat: notify other nodes if user has reconnected for missed messages
8ecb25e 
Closes #58
@bbangert bbangert mentioned this issue Aug 24, 2018
Merged
@bbangert bbangert self-assigned this Aug 24, 2018
bbangert added a commit that referenced this issue Aug 24, 2018
@bbangert
feat: notify other nodes if user has reconnected for missed messages
ac8bc79 
Closes #58
bbangert added a commit that referenced this issue Aug 24, 2018
@bbangert
feat: notify other nodes if user has reconnected for missed messages
10152fc 
Closes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbangert bbangert

Labels
enhancement New feature or request p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @bbangert