Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct signer_requests prometheus metric #1099

Merged
merged 1 commit into from
Jan 16, 2025
Merged

correct signer_requests prometheus metric #1099

merged 1 commit into from
Jan 16, 2025

Conversation

jmhodges
Copy link
Contributor

Forgot to use promauto to automatically register the metric with the
default prometheus registry (prometheus.DefaultRegistry).

Without this or a call to prometheus.Registry.Register somewhere, the
metric doesn't actually get emitted.

Updates AUT-199
Updates AUT-393

@jmhodges
correct signer_requests prometheus metric
17f31ad 
Forgot to use `promauto` to automatically register the metric with the
default prometheus registry (`prometheus.DefaultRegistry`).

Without this or a call to `prometheus.Registry.Register` somewhere, the
metric doesn't actually get emitted.

Updates AUT-199
Updates AUT-393
@jmhodges jmhodges marked this pull request as ready for review January 16, 2025 19:48
@jmhodges jmhodges requested review from a team as code owners January 16, 2025 19:48
@jmhodges jmhodges requested review from bhearsum and removed request for a team January 16, 2025 19:48
@jmhodges jmhodges merged commit 6682faa into main Jan 16, 2025
14 checks passed
@jmhodges jmhodges deleted the correct-signer-requests-prom branch January 16, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@say-yawn say-yawn say-yawn approved these changes

@bhearsum bhearsum Awaiting requested review from bhearsum bhearsum is a code owner automatically assigned from mozilla-services/autograph-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmhodges @say-yawn