Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add direct-to-prometheus metric for signer requests #1095

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jmhodges
Copy link
Contributor

We could have misunderstood what the problem is by looking at a metric
that only changed before the first scrape.

Updates AUT-393
Updates AUT-199

We could have misunderstood what the problem is by looking at a metric
that only changed before the first scrape.

Updates AUT-393
Updates AUT-199
@jmhodges jmhodges marked this pull request as ready for review January 14, 2025 22:50
@jmhodges jmhodges requested review from a team as code owners January 14, 2025 22:50
@jmhodges jmhodges requested review from say-yawn and removed request for a team January 14, 2025 22:50
@say-yawn say-yawn self-requested a review January 14, 2025 22:54
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was reading about NewCounterVec. LGTM

@jmhodges jmhodges merged commit 13cee03 into main Jan 14, 2025
14 checks passed
@jmhodges jmhodges deleted the aut-393-export-signer-to-prom branch January 14, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants