add prometheus and counter for testing #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22f33bc to
bfe30b9
Compare
bfe30b9 to
ec3267e
Compare
jbuck
approved these changes
Jan 13, 2025
ec3267e to
5f86805
Compare
Our statsd integration with prometheus has been turning counters that should be 1 into 0. It's unclear why this is happening and this patch is an attempt to debug the issue further. The foobar_test counter added here is to help determine why. It's incremented once on boot in both the prometheus and in statsd. We'll determine if the problem is in prometheus, grafana, telegraf, or in our statsd client (unlikely this last one) by emitting in both and seeing how they're captured. The rest of the org is standardizing on prometheus for metrics up and down the stack, so we should do the same, anyway. We don't commit to migrating all of the existing metrics here, but make it plausible to do so. This adds the port 2112 to Dockerfile for autograph as the place where the prometheus metrics are served from. Follow up patches in our infra-as-code will add the fetching of prometheus metrics. Updates AUT-393 Updates AUT-199
5f86805 to
d61a8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our statsd integration with prometheus has been turning counters that
should be 1 into 0. It's unclear why this is happening and this patch is
an attempt to debug the issue further.
The foobar_test counter added here is to help determine why. It's
incremented once on boot in both the prometheus and in statsd. We'll
determine if the problem is in prometheus, grafana, telegraf, or in our
statsd client (unlikely this last one) by emitting in both and seeing
how they're captured.
The rest of the org is standardizing on prometheus for metrics up and
down the stack, so we should do the same, anyway. We don't commit to
migrating all of the existing metrics here, but make it plausible to do
so.
This adds the port 2112 to Dockerfile for autograph as the place where
the prometheus metrics are served from.
Follow up patches in our infra-as-code will add the fetching of
prometheus metrics.
Updates AUT-393
Updates AUT-199