migrate to github.com/DataDog/datadog-go/v5/statsd #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates us to the v5 major version channel of DataDog's statsd client. Specifically, we bump to v5.6.0. This was done by running: ``` $ gofmt -w -r '"github.com/DataDog/datadog-go/statsd" -> "github.com/DataDog/datadog-go/v5/statsd"' . $ go mod tidy $ go mod vendor ``` Then, using the new client consturction api. We set the namespace and don't set the buflen size anymore, as the default is now optimized for each transport. See statsd.WithBufferPoolSize for more information on that. Along the way, we updated our mockstatsd with mockgen. See the command in that comments of that generated file to reproduce that work.
63370b0 to
14851a8
Compare
say-yawn
approved these changes
Jan 13, 2025
|
Mostly focused my review in comparing changes on |
|
Good checks! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates us to the v5 major version channel of DataDog's statsd
client. Specifically, we bump to v5.6.0.
This was done by running:
Then, using the new client construction api.
We set the namespace and don't set the buflen size anymore, as the
default is now optimized for each transport. See
statsd.WithBufferPoolSize for more information on that.
Along the way, we updated our mockstatsd with mockgen. See the command
in that comments of that generated file to reproduce that work.