upgrade statsd: github.com/DataDog/datadog-go to v4.8.3+incompatible from v3.7.2+incompatible #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7.2+incompatible This doesn't quite get us to a version of datadog-go that fully supported Go modules (see the "+incompatible" suffix), but this bump gets us closer. Inspecting <https://pkg.go.dev/github.com/DataDog/datadog-go> tells us there's a v5 version we should be importing: <https://pkg.go.dev/github.com/DataDog/datadog-go/v5>. We can do that after performing this upgrade and seeing it work well. This change was made by running: ``` $ go get github.com/DataDog/datadog-go@latest $ go mod tidy $ go mod vendor ```
say-yawn
approved these changes
Dec 9, 2024
@say-yawn A previous maintainer had explicitly closed and paused the updates for this dependency back in 2021 in #803 . That pause was done because he was not a software engineer and couldn't vet the dependency. This PR will reopen this line of deps to be automatically updated. I've been slow-rolling version bumps. You can see all the things we're behind on by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't quite get us to a version of datadog-go that fully
supported Go modules (see the "+incompatible" suffix), but this bump
gets us closer.
Inspecting https://pkg.go.dev/github.com/DataDog/datadog-go tells us
there's a v5 version we should be importing:
https://pkg.go.dev/github.com/DataDog/datadog-go/v5. We can do that
after performing this upgrade and seeing it work well.
This change was made by running: